eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 21:12:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS/Bytecode: Correctly rethrow exception in await expression

Browse Source 
We were implicitly converting the throw completion's value into a normal
completion in `AsyncFunctionDriverWrapper::continue_async_execution`,
which meant the routine generated by `generate_await` didn't know that
the value had to be thrown when execution resumed.

Without this change, we mistakenly pass 13 tests for `Array.fromAsync`,
which we do not implement yet. But even with that "regression", we pass
17 more test262 tests in total.
This commit is contained in:
Daniel Bertalan
2023-07-14 21:49:39 +02:00
committed by Andreas Kling
parent cff8f56ce7
commit 2a563b9de6
Notes: sideshowbarker 2024-07-17 06:09:44 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/2a563b9de6
Pull-request: https://github.com/SerenityOS/serenity/pull/20026
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/AsyncFunctionDriverWrapper.cpp
View File

@@ -114,7 +114,7 @@ void AsyncFunctionDriverWrapper::continue_async_execution(VM& vm, Value value, b
continue;
}
if (m_current_promise->state() == Promise::State::Rejected) {
generator_result = m_generator_object->resume_abrupt(vm, m_current_promise->result(), {});
generator_result = m_generator_object->resume_abrupt(vm, throw_completion(m_current_promise->result()), {});
continue;
}
// Due to the nature of promise capabilities we might get called on either one path,