eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 02:27:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Use narrower types in Temporal PlainDate/PlainDateTime/Calendar

Browse Source 
These are bounds-checked during construction of PlainDate/PlainDateTime
and as such theres no need to widen them in these internal AO calls.
This commit is contained in:
Idan Horowitz
2021-07-26 16:48:47 +03:00
committed by Linus Groh
parent c5c32ad274
commit 2c6bd3a61b
Notes: sideshowbarker 2024-07-18 08:18:57 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/2c6bd3a61b3
Pull-request: https://github.com/SerenityOS/serenity/pull/9023
Reviewed-by: https://github.com/linusg ✅
11 changed files with 47 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp
View File

@@ -577,9 +577,9 @@ Optional<TemporalTimeZone> parse_temporal_time_zone_string(GlobalObject& global_
VERIFY(sign_part.has_value());
// b. Set hours to ! ToIntegerOrInfinity(hours).
i32 hours = Value(js_string(vm, *hours_part)).to_integer_or_infinity(global_object);
u8 hours = Value(js_string(vm, *hours_part)).to_integer_or_infinity(global_object);
i32 sign;
u8 sign;
// c. If sign is the code unit 0x002D (HYPHEN-MINUS) or the code unit 0x2212 (MINUS SIGN), then
if (sign_part->is_one_of("-", "\u2212")) {
// i. Set sign to −1.
@@ -592,10 +592,10 @@ Optional<TemporalTimeZone> parse_temporal_time_zone_string(GlobalObject& global_
}
// e. Set minutes to ! ToIntegerOrInfinity(minutes).
i32 minutes = Value(js_string(vm, minutes_part.value_or(""sv))).to_integer_or_infinity(global_object);
u8 minutes = Value(js_string(vm, minutes_part.value_or(""sv))).to_integer_or_infinity(global_object);
// f. Set seconds to ! ToIntegerOrInfinity(seconds).
i32 seconds = Value(js_string(vm, seconds_part.value_or(""sv))).to_integer_or_infinity(global_object);
u8 seconds = Value(js_string(vm, seconds_part.value_or(""sv))).to_integer_or_infinity(global_object);
i32 nanoseconds;
// g. If fraction is not undefined, then