eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't store GC::Root<JS::ArrayBuffer> in FileAPI::FileReader

Browse Source 
This was creating a reference cycle and leaking the realm.
This commit is contained in:
Andreas Kling
2025-12-26 06:56:24 +01:00
committed by Jelle Raaijmakers
parent b291d75289
commit 2d2078d439
Notes: github-actions[bot] 2025-12-26 10:58:18 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/2d2078d4393
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7236
Reviewed-by: https://github.com/gmta ✅
4 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/FileAPI/FileReader.h
View File

@@ -21,7 +21,7 @@ class FileReader : public DOM::EventTarget {
GC_DECLARE_ALLOCATOR(FileReader);
public:
using Result = Variant<Empty, String, GC::Root<JS::ArrayBuffer>>;
using Result = Variant<Empty, String, GC::Ref<JS::ArrayBuffer>>;
virtual ~FileReader() override;