eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Register shutdown-on-close handler once in ReadableStreamPipeTo

Browse Source 
Previously, we added a `reader.closed()` promise reaction during every
`ReadableStreamPipeTo::process()` call, which meant allocating a new
reaction objects for every processed chunk and retaining all of them
until the stream closed. The same issue existed for `writer.closed()`
inside `ReadableStreamPipeTo::read_chunk()`.

This change registers a single shutdown handler for both the reader and
the writer in the ReadableStreamPipeTo constructor.
This commit is contained in:
Aliaksandr Kalenik
2025-12-08 18:53:33 +01:00
committed by Tim Flynn
parent d852b59d99
commit 2e9c8ab669
Notes: github-actions[bot] 2025-12-08 18:58:39 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/2e9c8ab669f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7061
Reviewed-by: https://github.com/trflynn89 ✅
2 changed files with 14 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
Libraries/LibWeb/Streams/ReadableStreamPipeTo.cpp
View File

@@ -83,11 +83,20 @@ ReadableStreamPipeTo::ReadableStreamPipeTo(
, m_destination(destination)
, m_reader(reader)
, m_writer(writer)
, m_on_shutdown(GC::create_function(heap(), [this](JS::Value) -> WebIDL::ExceptionOr<JS::Value> {
check_for_error_and_close_states();
return JS::js_undefined();
}))
, m_prevent_close(prevent_close)
, m_prevent_abort(prevent_abort)
, m_prevent_cancel(prevent_cancel)
{
m_reader->set_readable_stream_pipe_to_operation({}, this);
if (auto reader_closed_promise = m_reader->closed())
WebIDL::react_to_promise(*reader_closed_promise, m_on_shutdown, m_on_shutdown);
if (auto writer_closed_promise = m_writer->closed())
WebIDL::react_to_promise(*writer_closed_promise, m_on_shutdown, m_on_shutdown);
}
void ReadableStreamPipeTo::visit_edges(Cell::Visitor& visitor)
@@ -102,6 +111,7 @@ void ReadableStreamPipeTo::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_signal);
visitor.visit(m_last_write_promise);
visitor.visit(m_unwritten_chunks);
visitor.visit(m_on_shutdown);
}
void ReadableStreamPipeTo::process()
@@ -121,15 +131,8 @@ void ReadableStreamPipeTo::process()
return JS::js_undefined();
});
auto shutdown = GC::create_function(heap(), [this](JS::Value) -> WebIDL::ExceptionOr<JS::Value> {
check_for_error_and_close_states();
return JS::js_undefined();
});
if (ready_promise)
WebIDL::react_to_promise(*ready_promise, when_ready, shutdown);
if (auto promise = m_reader->closed())
WebIDL::react_to_promise(*promise, shutdown, shutdown);
WebIDL::react_to_promise(*ready_promise, when_ready, m_on_shutdown);
}
void ReadableStreamPipeTo::set_abort_signal(GC::Ref<DOM::AbortSignal> signal, DOM::AbortSignal::AbortSignal::AbortAlgorithmID signal_id)
@@ -235,16 +238,8 @@ void ReadableStreamPipeTo::read_chunk()
finish();
});
auto shutdown = GC::create_function(heap(), [this](JS::Value) -> WebIDL::ExceptionOr<JS::Value> {
check_for_error_and_close_states();
return JS::js_undefined();
});
auto read_request = heap().allocate<ReadableStreamPipeToReadRequest>(on_chunk, on_complete, shutdown);
auto read_request = heap().allocate<ReadableStreamPipeToReadRequest>(on_chunk, on_complete, *m_on_shutdown);
readable_stream_default_reader_read(m_reader, read_request);
if (auto promise = m_writer->closed())
WebIDL::react_to_promise(*promise, shutdown, shutdown);
}
void ReadableStreamPipeTo::write_chunk()