eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Fire load event for non-string javascript: URLs

Browse Source 
Corresponds to 8abe559982

The relevant test doesn't pass, so we're probably missing some other
part of this mechanism:
https://wpt.live/html/semantics/embedded-content/the-embed-element/embed-javascript-url.html
This commit is contained in:
Sam Atkins
2025-05-15 12:28:53 +01:00
committed by Shannon Booth
parent 27ba216e3f
commit 2efad4c941
Notes: github-actions[bot] 2025-05-15 22:22:15 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/2efad4c9415
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4749
8 changed files with 41 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
View File

@@ -93,7 +93,7 @@ void HTMLIFrameElement::post_connection()
// value and insertedNode's iframe sandboxing flag set.
// 3. Process the iframe attributes for insertedNode, with initialInsertion set to true.
process_the_iframe_attributes(true);
process_the_iframe_attributes(InitialInsertion::Yes);
if (auto navigable = content_navigable()) {
auto traversable = navigable->traversable_navigable();
@@ -105,7 +105,7 @@ void HTMLIFrameElement::post_connection()
}
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#process-the-iframe-attributes
void HTMLIFrameElement::process_the_iframe_attributes(bool initial_insertion)
void HTMLIFrameElement::process_the_iframe_attributes(InitialInsertion initial_insertion)
{
if (!content_navigable())
return;
@@ -152,7 +152,7 @@ void HTMLIFrameElement::process_the_iframe_attributes(bool initial_insertion)
}
// 3. If url matches about:blank and initialInsertion is true, then:
if (url_matches_about_blank(*url) && initial_insertion) {
if (url_matches_about_blank(*url) && initial_insertion == InitialInsertion::Yes) {
// 1. Run the iframe load event steps given element.
run_iframe_load_event_steps(*this);