eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-02 04:27:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Do not fully qualify references to CanonicalizeUnicodeLocaleId

Browse Source 
This might've been needed at some point to disambiguate between another
function of the same name that is in LibLocale. But now that it takes a
VM parameter, it is for sure clear to the compiler what is being called.
This commit is contained in:
Timothy Flynn
2023-01-19 11:40:17 -05:00
committed by Linus Groh
parent 1e6e719592
commit 2f1184ccdb
Notes: sideshowbarker 2024-07-17 22:41:14 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/2f1184ccdb
Pull-request: https://github.com/SerenityOS/serenity/pull/17092
Reviewed-by: https://github.com/linusg
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/Intl/AbstractOperations.cpp
View File

@@ -250,7 +250,7 @@ ThrowCompletionOr<Vector<DeprecatedString>> canonicalize_locale_list(VM& vm, Val
// vi. Let canonicalizedTag be ! CanonicalizeUnicodeLocaleId(tag).
// NOTE: We TRY this operation only to propagate OOM errors.
auto canonicalized_tag = TRY(JS::Intl::canonicalize_unicode_locale_id(vm, *locale_id));
auto canonicalized_tag = TRY(canonicalize_unicode_locale_id(vm, *locale_id));
// vii. If canonicalizedTag is not an element of seen, append canonicalizedTag as the last element of seen.
if (!seen.contains_slow(canonicalized_tag))
@@ -353,7 +353,7 @@ ThrowCompletionOr<DeprecatedString> insert_unicode_extension_and_canonicalize(VM
// of that string. LibUnicode gives us the parsed locale in a structure, so we can mutate that
// structure directly.
TRY_OR_THROW_OOM(vm, locale.extensions.try_append(move(extension)));
return TRY(JS::Intl::canonicalize_unicode_locale_id(vm, locale));
return TRY(canonicalize_unicode_locale_id(vm, locale));
}
template<typename T>