eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 11:37:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Use default input size (20) when value is 0

Browse Source 
According to the HTML specification, the `size` attribute of an input
element must be a valid non-negative integer greater than zero. If the
value is invalid or set to `0`, the default size of `20` should be used.

This small change fixes one issue identified in
https://wpt.live/html/rendering/widgets/input-text-size.html
The WPT test suite was also automatically imported.
This commit is contained in:
Khaled Lakehal
2024-11-25 22:40:22 +01:00
committed by Tim Ledbetter
parent 58828ffd62
commit 2f51e9a98e
Notes: github-actions[bot] 2024-11-26 10:02:56 +00:00 
Author: https://github.com/khaledev
Commit: https://github.com/LadybirdBrowser/ladybird/commit/2f51e9a98e9
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2580
Reviewed-by: https://github.com/gmta ✅
Reviewed-by: https://github.com/tcl3
3 changed files with 63 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Tests/LibWeb/Text/expected/wpt-import/html/rendering/widgets/input-text-size.txt Normal file
View File

@@ -0,0 +1,16 @@
Summary
Harness status: OK
Rerun
Found 5 tests
4 Pass
1 Fail
Details
Result Test Name MessagePass A misssing attribute is equivalent to size=20
Pass An invalid attribute value is equivalent to size=20
Pass The width depends on a size attribute
Pass Size attribute value affects layout-dependent computed style
Fail Size attribute value is not a presentational hint