eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Draw canvas arcs and ellipses correctly when radius is zero

Browse Source 
In this case, we should just draw a line from the last point in the
path to the start point. Previously, a division by zero caused nothing
to be drawn.
This commit is contained in:
Tim Ledbetter
2025-10-22 14:32:04 +01:00
committed by Jelle Raaijmakers
parent 865699066e
commit 2fd424ccb6
Notes: github-actions[bot] 2025-10-22 14:11:08 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/2fd424ccb6f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6546
Reviewed-by: https://github.com/gmta ✅
3 changed files with 55 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
Tests/LibWeb/Text/input/wpt-import/html/canvas/element/path-objects/2d.path.arc.zeroradius.html Normal file
View File

@@ -0,0 +1,35 @@
<!DOCTYPE html>
<!-- DO NOT EDIT! This test has been generated by /html/canvas/tools/gentest.py. -->
<meta charset="UTF-8">
<title>Canvas test: 2d.path.arc.zeroradius</title>
<script src="../../../../resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script>
<script src="../../../../html/canvas/resources/canvas-tests.js"></script>
<link rel="stylesheet" href="../../../../html/canvas/resources/canvas-tests.css">
<body class="show_output">
<h1>2d.path.arc.zeroradius</h1>
<p class="desc">arc() with zero radius draws a line to the start point</p>
<p class="output">Actual output:</p>
<canvas id="c" class="output" width="100" height="50"><p class="fallback">FAIL (fallback content)</p></canvas>
<p class="output expectedtext">Expected output:<p><img src="../../../../images/green-100x50.png" class="output expected" id="expected" alt="">
<ul id="d"></ul>
<script>
var t = async_test("arc() with zero radius draws a line to the start point");
_addTest(function(canvas, ctx) {
ctx.fillStyle = '#f00'
ctx.fillRect(0, 0, 100, 50);
ctx.lineWidth = 50;
ctx.strokeStyle = '#0f0';
ctx.beginPath();
ctx.moveTo(0, 25);
ctx.arc(200, 25, 0, 0, Math.PI, true);
ctx.stroke();
_assertPixel(canvas, 50,25, 0,255,0,255);
});
</script>