eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Skip shorthand serialization for var() longhands

Browse Source 
When CSSRule.cssText is accessed, shorthands are recomposed from
individual longhand declarations. For coordinating-list shorthands, the
`serialize()` function always assumed that each  sub-property was a
value list. This caused a  crash for longhands containing `var()`. We
now fall back to serializing properties individually if any sub
property contains `var()`. This matches the behavior of other engines.
This commit is contained in:
Tim Ledbetter
2026-03-02 15:22:59 +00:00
committed by Jelle Raaijmakers
parent 710c44a021
commit 30d528d3c0
Notes: github-actions[bot] 2026-03-06 12:44:41 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/30d528d3c06
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8250
Reviewed-by: https://github.com/gmta ✅
3 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/css/transition-longhand-var-serialization.txt Normal file
View File

@@ -0,0 +1 @@
.a { transition-property: var(--a); transition-duration: var(--b); transition-timing-function: var(--c); transition-delay: var(--d); transition-behavior: var(--e); }