eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWasm: Take memory_fill arguments in the right order

Browse Source 
This makes ruffle.rs work again :^)
This commit is contained in:
Ali Mohammad Pur
2025-10-04 09:16:21 +02:00
committed by Jelle Raaijmakers
parent 353febfab6
commit 31da9ab4e8
Notes: github-actions[bot] 2025-10-04 09:18:11 +00:00 
Author: https://github.com/alimpfard
Commit: https://github.com/LadybirdBrowser/ladybird/commit/31da9ab4e82
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6389
Reviewed-by: https://github.com/gmta ✅
3 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWasm/AbstractMachine/BytecodeInterpreter.cpp
View File

@@ -1581,6 +1581,7 @@ HANDLE_INSTRUCTION(memory_fill)
auto instance = configuration.store().get(address);
// bounds checked by verifier.
auto count = configuration.take_source(0, addresses.sources).to<u32>();
u8 value = static_cast<u8>(configuration.take_source(1, addresses.sources).to<u32>());
auto destination_offset = configuration.take_source(2, addresses.sources).to<u32>();
Checked<u32> checked_end = destination_offset;
@@ -1591,7 +1592,6 @@ HANDLE_INSTRUCTION(memory_fill)
TAILCALL return continue_(HANDLER_PARAMS(DECOMPOSE_PARAMS_NAME_ONLY));
Instruction::MemoryArgument memarg { 0, 0, args.memory_index };
u8 value = static_cast<u8>(configuration.take_source(1, addresses.sources).to<u32>());
for (u32 i = 0; i < count; ++i) {
if (interpreter.store_to_memory(configuration, memarg, { &value, sizeof(value) }, destination_offset + i))
return Outcome::Return;