eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 02:05:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Add missing visit_edges() for ImageStyleValue

Browse Source 
ImageStyleValue has a visit_edges() method, although it is not a
GC-allocated object. This is necessary because it owns a GC-allocated
ImageRequest that we want to visit, instead of using JS::Handle, to
avoid leaks. In the future, we might want to make StyleValue be
GC-allocated.

For now, this change adds missing visit_edges() calls for objects that
own ImageStyleValue.
This commit is contained in:
Aliaksandr Kalenik
2023-09-28 00:26:02 +02:00
committed by Andreas Kling
parent b43b3d2f8d
commit 32be413f4e
Notes: sideshowbarker 2024-07-17 07:19:27 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/32be413f4e
Pull-request: https://github.com/SerenityOS/serenity/pull/21247
4 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/HTMLBodyElement.h
View File

@@ -29,6 +29,8 @@ public:
private:
HTMLBodyElement(DOM::Document&, DOM::QualifiedName);
virtual void visit_edges(Visitor&) override;
// ^DOM::Node
virtual bool is_html_body_element() const override { return true; }