eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

WindowServer: Ensure menu visibility after pushing menu to the stack

Browse Source 
We need to make sure the menu was pushed to the open menu stack before
calling set_visible, as this may trigger cursor re-evaluation, which
in turn expects the menu to be considered open.

Fixes #10836
This commit is contained in:
Tom
2021-11-12 14:16:53 -07:00
committed by Andreas Kling
parent 81786f6abe
commit 32d59257d6
Notes: sideshowbarker 2024-07-18 01:13:52 +09:00 
Author: https://github.com/tomuta
Commit: https://github.com/SerenityOS/serenity/commit/32d59257d65
Pull-request: https://github.com/SerenityOS/serenity/pull/10885
Issue: https://github.com/SerenityOS/serenity/issues/10836
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Services/WindowServer/MenuManager.cpp
View File

@@ -298,6 +298,8 @@ void MenuManager::open_menu(Menu& menu, bool as_current_menu)
m_open_menu_stack.append(menu);
menu.set_visible(true);
if (!menu.is_empty()) {
menu.redraw_if_theme_changed();
auto* window = menu.menu_window();