eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 02:27:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Support inserting non-inline elements into inline elements

Browse Source 
Our layout tree requires that all containers either have inline or
non-inline children. In order to support the layout of non-inline
elements inside inline elements, we need to do a bit of tree
restructuring. It effectively simulates temporarily closing all inline
nodes, appending the block element, and resumes appending to the last
open inline node.

The acid1.txt expectation needed to be updated to reflect the fact that
we now hoist its <p> elements out of the inline <form> they were in.
Visually, the before and after situations for acid1.html are identical.
This commit is contained in:
Jelle Raaijmakers
2025-01-15 16:37:30 +01:00
committed by Jelle Raaijmakers
parent 7eb4f3da37
commit 336684bc5c
Notes: github-actions[bot] 2025-01-23 08:34:24 +00:00 
Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/336684bc5cb
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3276
Reviewed-by: https://github.com/kalenikaliaksandr ✅
18 changed files with 520 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
Tests/LibWeb/Ref/input/block-element-inside-inline-element.html Normal file
View File

@@ -0,0 +1,44 @@
<!DOCTYPE html>
<html>
<head>
<link rel="match" href="../expected/block-element-inside-inline-element-ref.html" />
</head>
<body>
<!-- Block at end of inline element -->
<b>foo<div>bar</div></b>
<!-- Block at beginning of inline element -->
<hr>
<b><div>foo</div>bar</b>
<!-- Block in middle of inline element -->
<hr>
<b>foo<div>bar</div>baz</b>
<!-- Block in middle of two inline elements -->
<hr>
<b>foo<i>bar<div>baz</div>lorem</i>ipsum</b>
<!-- Multiple subsequent blocks -->
<hr>
<b>foo<div>bar</div><div>baz</div>lorem</b>
<!-- Multiple subsequent blocks with inline element between them -->
<hr>
<b>foo<div>bar</div><u>baz</u><div>lorem</div>ipsum</b>
<!-- Block in inline element following inline element -->
<hr>
<div>foo<b><div>bar</div></b></div>
<!-- Dynamic tree mutation test -->
<hr>
<div id="target1"></div>
<script>
document.querySelector('#target1').innerHTML = '<b>foo<div>bar</div>baz</b>';
</script>
<!-- Dynamic style update -->
<hr>
<span id="target2" style="font-weight: bold">foo <div>bar</div></span>
<script>
window.addEventListener('DOMContentLoaded', () => {
document.body.offsetWidth; // force layout
const target2 = document.querySelector('#target2');
target2.setAttribute('style', null);
});
</script>
</body>
</html>