eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Visit IntersectionObserverRegistration instead of using Handle

Browse Source 
This fixes GC-leak caused by JS::Handle<IntersectionObserverver>
preventing an element that owns the handle from being deallocated.
This commit is contained in:
Aliaksandr Kalenik
2023-09-26 16:54:39 +02:00
committed by Andreas Kling
parent ac5c4705fd
commit 35623ad52e
Notes: sideshowbarker 2024-07-17 05:06:13 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/35623ad52e
Pull-request: https://github.com/SerenityOS/serenity/pull/21235
3 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/IntersectionObserver/IntersectionObserver.h
View File

@@ -23,7 +23,7 @@ struct IntersectionObserverInit {
struct IntersectionObserverRegistration {
// https://www.w3.org/TR/intersection-observer/#dom-intersectionobserverregistration-observer
// [A]n observer property holding an IntersectionObserver.
JS::Handle<IntersectionObserver> observer;
JS::NonnullGCPtr<IntersectionObserver> observer;
// https://www.w3.org/TR/intersection-observer/#dom-intersectionobserverregistration-observer
// NOTE: Optional is used in place of the spec using -1 to indicate no previous index.