eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibCore+Everywhere: Make Core::Stream::read() return Bytes

Browse Source 
A mistake I've repeatedly made is along these lines:
```c++
auto nread = TRY(source_file->read(buffer));
TRY(destination_file->write(buffer));
```

It's a little clunky to have to create a Bytes or StringView from the
buffer's data pointer and the nread, and easy to forget and just use
the buffer. So, this patch changes the read() function to return a
Bytes of the data that were just read.

The other read_foo() methods will be modified in the same way in
subsequent commits.

Fixes #13687
This commit is contained in:
Sam Atkins
2022-04-15 13:33:02 +01:00
committed by Tim Flynn
parent 6654efcd82
commit 3b1e063d30
Notes: sideshowbarker 2024-07-18 03:20:18 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/3b1e063d30
Pull-request: https://github.com/SerenityOS/serenity/pull/13694
Reviewed-by: https://github.com/trflynn89
22 changed files with 103 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibCore/InputBitStream.h
View File

@@ -31,7 +31,7 @@ public:
// ^Stream
virtual bool is_readable() const override { return m_stream.is_readable(); }
virtual ErrorOr<size_t> read(Bytes bytes) override
virtual ErrorOr<Bytes> read(Bytes bytes) override
{
if (m_current_byte.has_value() && is_aligned_to_byte_boundary()) {
bytes[0] = m_current_byte.release_value();