eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Draw caret for empty <input>s and <textarea>s

Browse Source 
Our change to generate spans in PaintableWithLines from fragments also
broke drawing the caret for empty <input>s and <textarea>s, since spans
was empty in that case.

Fix this by moving caret drawing to PaintableWithLines, and only
invoking it if we have a cursor position set.
This commit is contained in:
Jelle Raaijmakers
2026-02-10 11:26:13 +01:00
committed by Jelle Raaijmakers
parent a69df4d25b
commit 3bc4374344
Notes: github-actions[bot] 2026-02-11 10:29:24 +00:00 
Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/3bc43743440
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7859
6 changed files with 83 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Tests/LibWeb/Text/expected/display_list/input-caret.txt Normal file
View File

@@ -0,0 +1,13 @@
AccumulatedVisualContext Tree:
[1] scroll_frame_id=0 (PaintableWithLines(BlockContainer<PRE>#out))
[2] clip=[9,9 100x20] (PaintableWithLines(BlockContainer<DIV>))
DisplayList:
SaveLayer@0
FillRect@1 rect=[8,8 102x22] color=rgb(255, 255, 255)
FillPath@1 path_bounding_rect=[8,8 102x22]
DrawGlyphRun@2 rect=[11,10 37x18] translation=[11,23.796875] color=rgb(0, 0, 0)
FillRect@2 rect=[11,10 1x18] color=rgb(0, 0, 0)
FillPath@1 path_bounding_rect=[6,6 106x26]
Restore@0

19
Tests/LibWeb/Text/expected/display_list/textarea-caret.txt Normal file
View File

@@ -0,0 +1,19 @@
AccumulatedVisualContext Tree:
[1] scroll_frame_id=0 (PaintableWithLines(BlockContainer<PRE>#out))
[2] clip=[9,9 104x34] (PaintableWithLines(BlockContainer<DIV>))
DisplayList:
SaveLayer@0
FillRect@1 rect=[8,8 106x36] color=rgb(255, 255, 255)
FillPath@1 path_bounding_rect=[8,8 106x36]
DrawGlyphRun@2 rect=[11,11 30x15] translation=[11,22.390625] color=rgb(0, 0, 0)
FillRect@2 rect=[11,11 1x15] color=rgb(0, 0, 0)
FillPath@1 path_bounding_rect=[6,6 110x40]
DrawLine@1 from=[109,41] to=[111,39] color=rgba(255, 255, 255, 0.392) thickness=1
DrawLine@1 from=[108,41] to=[111,38] color=rgba(0, 0, 0, 0.392) thickness=1
DrawLine@1 from=[106,41] to=[111,36] color=rgba(255, 255, 255, 0.392) thickness=1
DrawLine@1 from=[105,41] to=[111,35] color=rgba(0, 0, 0, 0.392) thickness=1
DrawLine@1 from=[103,41] to=[111,33] color=rgba(255, 255, 255, 0.392) thickness=1
DrawLine@1 from=[102,41] to=[111,32] color=rgba(0, 0, 0, 0.392) thickness=1
Restore@0