mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-03 04:52:06 +02:00
LibJS: Make Value() default-construct the undefined value
The special empty value (that we use for array holes, Optional<Value> when empty and a few other other placeholder/sentinel tasks) still exists, but you now create one via JS::js_special_empty_value() and check for it with Value::is_special_empty_value(). The main idea here is to make it very unlikely to accidentally create an unexpected special empty value.
This commit is contained in:
committed by
Andreas Kling
parent
0d91363742
commit
3cf50539ec
Notes:
github-actions[bot]
2025-04-05 09:21:31 +00:00
Author: https://github.com/awesomekling Commit: https://github.com/LadybirdBrowser/ladybird/commit/3cf50539ec0 Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4232
@@ -51,14 +51,14 @@ static JS::Value create_close_sentinel()
|
||||
{
|
||||
// The close sentinel is a unique value enqueued into [[queue]], in lieu of a chunk, to signal that the stream is closed. It is only used internally, and is never exposed to web developers.
|
||||
// Note: We use the empty Value to signal this as, similarly to the note above, the empty value is not exposed to nor creatable by web developers.
|
||||
return {};
|
||||
return JS::js_special_empty_value();
|
||||
}
|
||||
|
||||
// https://streams.spec.whatwg.org/#close-sentinel
|
||||
// Non-standard function that implements the "If value is a close sentinel" check.
|
||||
static bool is_close_sentinel(JS::Value value)
|
||||
{
|
||||
return value.is_empty();
|
||||
return value.is_special_empty_value();
|
||||
}
|
||||
|
||||
// NON-STANDARD: Can be used instead of CreateReadableStream in cases where we need to set up a newly allocated
|
||||
|
||||
Reference in New Issue
Block a user