eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Only include direction if dirname applies

Browse Source 
This commit changes form data to only include the direction of auto
directionality form associated elements.
This commit is contained in:
Glenn Skrzypczak
2025-07-24 18:27:26 +02:00
committed by Tim Ledbetter
parent c5fc4a5ac2
commit 3dd8b3230e
Notes: github-actions[bot] 2025-08-02 17:28:47 +00:00 
Author: https://github.com/skyz1
Commit: https://github.com/LadybirdBrowser/ladybird/commit/3dd8b3230e7
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5583
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/tcl3 ✅
6 changed files with 109 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/HTML/FormControlInfrastructure.cpp
View File

@@ -189,10 +189,10 @@ WebIDL::ExceptionOr<Optional<Vector<XHR::FormDataEntry>>> construct_entry_list(J
entry_list.append(TRY(create_entry(realm, name.to_string(), control_as_form_associated_element->value().to_utf8_but_should_be_ported_to_utf16())));
}
// 11. If the element has a dirname attribute, and that attribute's value is not the empty string, then:
if (auto attribute = control->get_attribute(HTML::AttributeNames::dirname); attribute.has_value() && !attribute.value().is_empty()) {
// 11. If the element has a dirname attribute, that attribute's value is not the empty string, and the element is an auto-directionality form-associated element:
if (auto attribute = control->get_attribute(HTML::AttributeNames::dirname); attribute.has_value() && !attribute.value().is_empty() && control->is_auto_directionality_form_associated_element()) {
// 1. Let dirname be the value of the element's dirname attribute.
String dirname = attribute.value();
String const& dirname = attribute.value();
// 2. Let dir be the string "ltr" if the directionality of the element is 'ltr', and "rtl" otherwise (i.e., when the directionality of the element is 'rtl').
String dir = MUST((control->directionality() == DOM::Element::Directionality::Ltr) ? String::from_utf8("ltr"sv) : String::from_utf8("rtl"sv));