eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Userland: Prefer _string over _short_string

Browse Source 
As `_string` can't fail anymore (since 3434412), there are no real
benefits to use the short variant in most cases.
This commit is contained in:
Lucas CHOLLET
2023-08-07 22:26:17 -04:00
committed by Andreas Kling
parent a5edc9cdfc
commit 3f35ffb648
Notes: sideshowbarker 2024-07-17 06:00:02 +09:00 
Author: https://github.com/LucasChollet
Commit: https://github.com/SerenityOS/serenity/commit/3f35ffb648
Pull-request: https://github.com/SerenityOS/serenity/pull/20418
198 changed files with 684 additions and 684 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSMediaFeatureID.cpp
View File

@@ -145,7 +145,7 @@ bool media_feature_type_is_range(MediaFeatureID media_feature_id)
VERIFY(feature.has("type"sv));
auto feature_type = feature.get_deprecated_string("type"sv);
VERIFY(feature_type.has_value());
TRY(member_generator.set("is_range", feature_type.value() == "range" ? "true"_short_string : "false"_short_string));
TRY(member_generator.set("is_range", feature_type.value() == "range" ? "true"_string : "false"_string));
TRY(member_generator.try_append(R"~~~(
case MediaFeatureID::@name:titlecase@:
return @is_range@;)~~~"));