eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 22:52:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibGL+LibSoftGPU: Pass along lighting flag to Software GPU

Browse Source 
This was currently only set in the OpenGL context, as the previous
architecture did all of the transformation in LibGL before passing the
transformed triangles onto the rasterizer. As this has now changed, and
we require the vertex data to be in eye-space before we can apply
lighting, we need to pass this flag along as well via the GPU options.
This commit is contained in:
Jesse Buhagiar
2022-01-08 18:52:12 +11:00
committed by Linus Groh
parent 775ef000e0
commit 4035532ee8
Notes: sideshowbarker 2024-07-17 21:06:24 +09:00 
Author: https://github.com/Quaker762
Commit: https://github.com/SerenityOS/serenity/commit/4035532ee87
Pull-request: https://github.com/SerenityOS/serenity/pull/11764
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/linusg
Reviewed-by: https://github.com/sunverwerth ✅
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibGL/SoftwareGLContext.cpp
View File

@@ -668,6 +668,8 @@ void SoftwareGLContext::gl_enable(GLenum capability)
break;
case GL_LIGHTING:
m_lighting_enabled = true;
rasterizer_options.lighting_enabled = true;
update_rasterizer_options = true;
break;
case GL_NORMALIZE:
m_normalize = true;
@@ -762,6 +764,8 @@ void SoftwareGLContext::gl_disable(GLenum capability)
break;
case GL_LIGHTING:
m_lighting_enabled = false;
rasterizer_options.lighting_enabled = false;
update_rasterizer_options = true;
break;
case GL_LIGHT0:
case GL_LIGHT1: