eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/CSS: Serialize shorthands with var() to original value

Browse Source
This commit is contained in:
Tim Ledbetter
2026-01-14 00:39:43 +00:00
committed by Sam Atkins
parent 4608987da9
commit 40d217bde2
Notes: github-actions[bot] 2026-01-15 11:51:47 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/40d217bde24
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7462
Reviewed-by: https://github.com/AtkinsSJ ✅
13 changed files with 181 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
Libraries/LibWeb/CSS/CSSStyleProperties.cpp
View File

@@ -18,6 +18,7 @@
#include <LibWeb/CSS/StyleValues/KeywordStyleValue.h>
#include <LibWeb/CSS/StyleValues/LengthStyleValue.h>
#include <LibWeb/CSS/StyleValues/NumberStyleValue.h>
#include <LibWeb/CSS/StyleValues/PendingSubstitutionStyleValue.h>
#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
#include <LibWeb/CSS/StyleValues/ShorthandStyleValue.h>
#include <LibWeb/CSS/StyleValues/StyleValueList.h>
@@ -486,6 +487,30 @@ Optional<StyleProperty> CSSStyleProperties::get_property_internal(PropertyNameAn
last_important_flag = declaration->important;
}
// https://drafts.csswg.org/css-values-5/#pending-substitution-value
// If all of the component longhand properties for a given shorthand are pending-substitution values from
// the same original shorthand value, the shorthand property must serialize to that original
// (arbitrary substitution function-containing) value.
// Otherwise, if any of the component longhand properties for a given shorthand are pending-substitution
// values, or contain arbitrary substitution functions of their own that have not yet been substituted, the
// shorthand property must serialize to the empty string.
if (list.first()->is_pending_substitution()) {
auto const& original_shorthand_value = list.first()->as_pending_substitution().original_shorthand_value();
auto all_from_same_original = all_of(list, [&](auto const& value) {
return value->is_pending_substitution()
&& &value->as_pending_substitution().original_shorthand_value() == &original_shorthand_value;
});
if (all_from_same_original) {
return StyleProperty {
.important = last_important_flag.value(),
.property_id = property.id(),
.value = original_shorthand_value,
};
}
}
if (any_of(list, [](auto const& value) { return value->is_pending_substitution() || value->is_unresolved(); }))
return {};
// 3. If important flags of all declarations in list are same, then return the serialization of list.
// NOTE: Currently we implement property-specific shorthand serialization in ShorthandStyleValue::to_string().
return StyleProperty {