eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibGfx: Remove ImageDecoderPlugin::initialize()

Browse Source 
No plugin is currently overriding the default implementation, which is a
no-op. So we can safely delete it.
This commit is contained in:
Lucas CHOLLET
2023-07-17 13:00:37 -04:00
committed by Sam Atkins
parent 3752facfbc
commit 4291288a31
Notes: sideshowbarker 2024-07-17 02:21:14 +09:00 
Author: https://github.com/LucasChollet
Commit: https://github.com/SerenityOS/serenity/commit/4291288a31
Pull-request: https://github.com/SerenityOS/serenity/pull/20076
Issue: https://github.com/SerenityOS/serenity/issues/19893
Reviewed-by: https://github.com/AtkinsSJ ✅
18 changed files with 17 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Userland/Libraries/LibGfx/ImageFormats/ImageDecoder.cpp
View File

@@ -49,10 +49,8 @@ static OwnPtr<ImageDecoderPlugin> probe_and_sniff_for_appropriate_plugin(Readonl
if (!sniff_result)
continue;
auto plugin_decoder = plugin.create(bytes);
if (!plugin_decoder.is_error()) {
if (!plugin_decoder.value()->initialize().is_error())
return plugin_decoder.release_value();
}
if (!plugin_decoder.is_error())
return plugin_decoder.release_value();
}
return {};
}
@@ -76,10 +74,8 @@ static OwnPtr<ImageDecoderPlugin> probe_and_sniff_for_appropriate_plugin_with_kn
if (!validation_result)
continue;
auto plugin_decoder = plugin.create(bytes);
if (!plugin_decoder.is_error()) {
if (!plugin_decoder.value()->initialize().is_error())
return plugin_decoder.release_value();
}
if (!plugin_decoder.is_error())
return plugin_decoder.release_value();
}
return {};
}