eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Implement Document's supported property names closer to the spec

Browse Source 
Our implementation was errantly matching HTML tags other than the list
specified by the spec. For example, a <meta name=title> tag would be a
match for document.title.

For example, bandcamp will dynamically update its title when audio is
played as follows:

    document.title = "▶︎ " + document.title;

And bandcamp also has a <meta name=title> tag. The result was that the
title would become "▶︎ [object HTMLMetaElement]".
This commit is contained in:
Timothy Flynn
2024-03-29 07:20:16 -04:00
committed by Tim Flynn
parent 8ff3cd6d76
commit 43e55668eb
Notes: sideshowbarker 2024-07-17 02:06:40 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/43e55668eb
Pull-request: https://github.com/SerenityOS/serenity/pull/23758
Reviewed-by: https://github.com/kalenikaliaksandr ✅
5 changed files with 76 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Tests/LibWeb/Text/input/DOM/Document-named-properties.html
View File

@@ -5,6 +5,7 @@
<img id="baz" src="http://www.example.com" alt="Example" />
<form name="foo">
</form>
<meta name="kangaroo" />
<script src="../include.js"></script>
<script>
test(() => {
@@ -41,5 +42,7 @@
document.body.removeChild(document.greg);
println(`no more greg or banana: ${document.greg === undefined}, ${document.banana === undefined}`);
println(`meta tag does not match: ${document.kangaroo === undefined}`);
});
</script>