eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Make class-specific members of ESFO lazily allocated

Browse Source 
We don't need the [[Fields]] and [[PrivateMethods]] slots for most ESFO
instances, so let's reduce their impact on class size!

This shrinks ESFO from 200 bytes to 160 bytes, allowing more allocations
before we have to collect garbage.
This commit is contained in:
Andreas Kling
2025-04-08 13:39:07 +02:00
committed by Andreas Kling
parent 2a9b6f1d97
commit 4593e19bcf
Notes: github-actions[bot] 2025-04-08 16:53:42 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/4593e19bcf4
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4283
Reviewed-by: https://github.com/Hendiadyoin1
Reviewed-by: https://github.com/trflynn89
3 changed files with 40 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
View File

@@ -649,21 +649,23 @@ void ECMAScriptFunctionObject::visit_edges(Visitor& visitor)
visitor.visit(m_bytecode_executable);
for (auto& field : m_fields) {
field.initializer.visit(
[&visitor](GC::Ref<ECMAScriptFunctionObject>& initializer) {
visitor.visit(initializer);
},
[&visitor](Value initializer) {
visitor.visit(initializer);
},
[](Empty) {});
if (auto* property_key_ptr = field.name.get_pointer<PropertyKey>(); property_key_ptr && property_key_ptr->is_symbol())
visitor.visit(property_key_ptr->as_symbol());
}
if (m_class_data) {
for (auto& field : m_class_data->fields) {
field.initializer.visit(
[&visitor](GC::Ref<ECMAScriptFunctionObject>& initializer) {
visitor.visit(initializer);
},
[&visitor](Value initializer) {
visitor.visit(initializer);
},
[](Empty) {});
if (auto* property_key_ptr = field.name.get_pointer<PropertyKey>(); property_key_ptr && property_key_ptr->is_symbol())
visitor.visit(property_key_ptr->as_symbol());
}
for (auto& private_element : m_private_methods)
visitor.visit(private_element.value);
for (auto& private_element : m_class_data->private_methods)
visitor.visit(private_element.value);
}
m_script_or_module.visit(
[](Empty) {},
@@ -960,4 +962,12 @@ void ECMAScriptFunctionObject::set_name(FlyString const& name)
m_name_string = PrimitiveString::create(vm, name);
MUST(define_property_or_throw(vm.names.name, { .value = m_name_string, .writable = false, .enumerable = false, .configurable = true }));
}
ECMAScriptFunctionObject::ClassData& ECMAScriptFunctionObject::ensure_class_data() const
{
if (!m_class_data)
m_class_data = make<ClassData>();
return *m_class_data;
}
}