eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

Applications: Fix visibility of Object-derivative constructors

Browse Source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake
2021-10-31 23:38:04 +01:00
committed by Andreas Kling
parent 6b75a4dfc3
commit 465af4c4d4
Notes: sideshowbarker 2024-07-18 01:33:10 +09:00 
Author: https://github.com/BenWiederhake
Commit: https://github.com/SerenityOS/serenity/commit/465af4c4d4f
Pull-request: https://github.com/SerenityOS/serenity/pull/10745
Reviewed-by: https://github.com/PeterBindels-TomTom
Reviewed-by: https://github.com/sin-ack ✅
13 changed files with 53 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Applications/Piano/AudioPlayerLoop.h
View File

@@ -17,17 +17,17 @@ class TrackManager;
// Wrapper class accepting custom events to advance the track playing and forward audio data to the system.
// This does not run on a separate thread, preventing IPC multithreading madness.
class AudioPlayerLoop : public Core::Object {
class AudioPlayerLoop final : public Core::Object {
C_OBJECT(AudioPlayerLoop)
public:
AudioPlayerLoop(TrackManager& track_manager, bool& need_to_write_wav, Audio::WavWriter& wav_writer);
void enqueue_audio();
void toggle_paused();
bool is_playing() { return m_should_play_audio; }
private:
AudioPlayerLoop(TrackManager& track_manager, bool& need_to_write_wav, Audio::WavWriter& wav_writer);
TrackManager& m_track_manager;
Array<Sample, sample_count> m_buffer;
Optional<Audio::ResampleHelper<double>> m_resampler;