eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 20:17:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Resolve HTMLFormElement.action relative to document base URL

Browse Source 
Rather than returning a relative URL, an absolutized URL is now
returned relative to the document base URL
This commit is contained in:
Tim Ledbetter
2024-09-08 00:51:59 +01:00
committed by Andreas Kling
parent 33c62be7f9
commit 48e5d28ec9
Notes: github-actions[bot] 2024-09-08 07:48:40 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/48e5d28ec98
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1321
3 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/HTMLFormElement.cpp
View File

@@ -604,12 +604,12 @@ String HTMLFormElement::action() const
// The action IDL attribute must reflect the content attribute of the same name, except that on getting, when the
// content attribute is missing or its value is the empty string, the element's node document's URL must be returned
// instead.
if (auto maybe_action = attribute(AttributeNames::action);
maybe_action.has_value() && !maybe_action.value().is_empty()) {
return maybe_action.value();
auto form_action_attribute = attribute(AttributeNames::action);
if (!form_action_attribute.has_value() || form_action_attribute.value().is_empty()) {
return document().url_string();
}
return MUST(document().url().to_string());
return MUST(document().base_url().complete_url(form_action_attribute.value()).to_string());
}
// https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#dom-fs-action