eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Remove unnecessary FunctionObject::name() virtual

Browse Source 
This allows us to remove the BoundFunction::m_name field, which we
were initializing with a formatted FlyString on every function binding,
despite never using it for anything.
This commit is contained in:
Andreas Kling
2025-04-09 22:31:12 +02:00
committed by Alexander Kalenik
parent 6bd2cf3195
commit 4a5863bcdb
Notes: github-actions[bot] 2025-04-10 02:01:55 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/4a5863bcdbc
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4305
11 changed files with 5 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibJS/Runtime/WrappedFunction.h
View File

@@ -22,9 +22,6 @@ public:
virtual ThrowCompletionOr<Value> internal_call(Value this_argument, ReadonlySpan<Value> arguments_list) override;
// FIXME: Remove this (and stop inventing random internal slots that shouldn't exist, jeez)
virtual FlyString const& name() const override { return m_wrapped_target_function->name(); }
virtual Realm* realm() const override { return m_realm; }
FunctionObject const& wrapped_target_function() const { return m_wrapped_target_function; }