eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 21:12:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Everywhere: Fix -Winconsistent-missing-override warnings from Clang

Browse Source 
This option is already enabled when building Lagom, so let's enable it
for the main build too. We will no longer be surprised by Lagom Clang
CI builds failing while everything compiles locally.

Furthermore, the stronger `-Wsuggest-override` warning is enabled in
this commit, which enforces the use of the `override` keyword in all
classes, not just those which already have some methods marked as
`override`. This works with both GCC and Clang.
This commit is contained in:
Daniel Bertalan
2021-12-04 10:09:09 +01:00
committed by Brian Gianforcaro
parent 813593a485
commit 4a81b33c07
Notes: sideshowbarker 2024-07-17 22:58:50 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/4a81b33c07c
Pull-request: https://github.com/SerenityOS/serenity/pull/11206
22 changed files with 45 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibSQL/AST/AST.h
View File

@@ -943,7 +943,7 @@ public:
bool has_selection() const { return !m_select_statement.is_null(); }
const RefPtr<Select>& select_statement() const { return m_select_statement; }
RefPtr<SQLResult> execute(ExecutionContext&) const;
virtual RefPtr<SQLResult> execute(ExecutionContext&) const override;
private:
RefPtr<CommonTableExpressionList> m_common_table_expression_list;