eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 17:55:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Generalize support for dimension attributes

Browse Source 
Rather than each element which supports dimension attributes needing to
implement parsing the attributes and setting the appropriate style, we
can generalize this functionality. This will also make each element more
closely resemble the spec text, as we will be effectively declaring, for
example, "The img element supports dimension attributes" in code.
This commit is contained in:
Timothy Flynn
2024-04-10 21:44:11 -04:00
committed by Andreas Kling
parent 058dd225dd
commit 4b1abcf61d
Notes: sideshowbarker 2024-07-17 00:59:43 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/4b1abcf61d
Pull-request: https://github.com/SerenityOS/serenity/pull/23928
Issue: https://github.com/SerenityOS/serenity/issues/23926
Reviewed-by: https://github.com/AtkinsSJ
8 changed files with 32 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -1525,24 +1525,6 @@ i32 HTMLInputElement::default_tab_index_value() const
return 0;
}
// https://html.spec.whatwg.org/multipage/input.html#image-button-state-(type=image):the-input-element-11
void HTMLInputElement::apply_presentational_hints(CSS::StyleProperties& style) const
{
// The input element supports dimension attributes.
if (type_state() != TypeAttributeState::ImageButton)
return;
for_each_attribute([&](auto& name, auto& value) {
if (name == HTML::AttributeNames::width) {
if (auto parsed_value = parse_dimension_value(value))
style.set_property(CSS::PropertyID::Width, parsed_value.release_nonnull());
} else if (name == HTML::AttributeNames::height) {
if (auto parsed_value = parse_dimension_value(value))
style.set_property(CSS::PropertyID::Height, parsed_value.release_nonnull());
}
});
}
// https://html.spec.whatwg.org/multipage/input.html#dom-input-maxlength
WebIDL::Long HTMLInputElement::max_length() const
{