eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Handle NaN and Infinite values in CSS round function

Browse Source 
Gains us 10 WPT tests
This commit is contained in:
Callum Law
2025-06-27 02:35:07 +12:00
committed by Sam Atkins
parent 376b992f0e
commit 4ba54a7a1c
Notes: github-actions[bot] 2025-08-08 10:45:07 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/4ba54a7a1c0
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5719
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/gmta
3 changed files with 59 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Tests/LibWeb/Text/expected/wpt-import/css/css-values/round-mod-rem-computed.txt
View File

@@ -2,8 +2,8 @@ Harness status: OK
Found 229 tests
211 Pass
18 Fail
215 Pass
14 Fail
Pass round(10,10) should be used-value-equivalent to 10
Pass mod(1,1) should be used-value-equivalent to 0
Pass rem(1,1) should be used-value-equivalent to 0
@@ -217,18 +217,18 @@ Pass round(to-zero, 0, -Infinity) should be used-value-equivalent to 0
Pass round(to-zero, 4, -Infinity) should be used-value-equivalent to 0
Pass round(to-zero, -0, -Infinity) should be used-value-equivalent to calc(-0)
Pass round(to-zero, -4, -Infinity) should be used-value-equivalent to calc(-0)
Fail round(up, 1, Infinity) should be used-value-equivalent to calc(Infinity)
Pass round(up, 1, Infinity) should be used-value-equivalent to calc(Infinity)
Pass round(up, 0, Infinity) should be used-value-equivalent to 0
Pass round(up, -1, Infinity) should be used-value-equivalent to calc(-0)
Fail round(up, 1, -Infinity) should be used-value-equivalent to calc(Infinity)
Pass round(up, 1, -Infinity) should be used-value-equivalent to calc(Infinity)
Pass round(up, 0, -Infinity) should be used-value-equivalent to 0
Pass round(up, -1, -Infinity) should be used-value-equivalent to calc(-0)
Pass round(down, 1, Infinity) should be used-value-equivalent to calc(-0)
Pass round(down, 0, Infinity) should be used-value-equivalent to 0
Fail round(down, -1, Infinity) should be used-value-equivalent to calc(-Infinity)
Pass round(down, -1, Infinity) should be used-value-equivalent to calc(-Infinity)
Pass round(down, 1, -Infinity) should be used-value-equivalent to calc(-0)
Pass round(down, 0, -Infinity) should be used-value-equivalent to 0
Fail round(down, -1, -Infinity) should be used-value-equivalent to calc(-Infinity)
Pass round(down, -1, -Infinity) should be used-value-equivalent to calc(-Infinity)
Pass mod(-0, Infinity) should be used-value-equivalent to calc(NaN)
Pass mod(0, -Infinity) should be used-value-equivalent to calc(NaN)
Pass mod(-4, Infinity) should be used-value-equivalent to calc(NaN)

8
Tests/LibWeb/Text/expected/wpt-import/css/css-values/signed-zero.txt
View File

@@ -2,8 +2,8 @@ Harness status: OK
Found 162 tests
154 Pass
8 Fail
156 Pass
6 Fail
Pass sign(calc(-0)) should be used-value-equivalent to 0
Pass clamp(-1, 1 / sign(calc(-0)), 1) should be used-value-equivalent to -1
Pass sign(calc( 0)) should be used-value-equivalent to 0
@@ -79,7 +79,7 @@ Pass clamp(-1, 1 / sign(round(nearest, -0, infinity)), 1) should be used-value-e
Pass sign(round(nearest, 0, infinity)) should be used-value-equivalent to 0
Pass clamp(-1, 1 / sign(round(nearest, 0, infinity)), 1) should be used-value-equivalent to 1
Pass sign(round(nearest, 1, infinity)) should be used-value-equivalent to 0
Fail clamp(-1, 1 / sign(round(nearest, 1, infinity)), 1) should be used-value-equivalent to 1
Pass clamp(-1, 1 / sign(round(nearest, 1, infinity)), 1) should be used-value-equivalent to 1
Pass sign(round(up, -1, infinity)) should be used-value-equivalent to 0
Pass clamp(-1, 1 / sign(round(up, -1, infinity)), 1) should be used-value-equivalent to -1
Pass sign(round(up, -0, infinity)) should be used-value-equivalent to 0
@@ -91,7 +91,7 @@ Pass clamp(-1, 1 / sign(round(down, -0, infinity)), 1) should be used-value-equi
Pass sign(round(down, 0, infinity)) should be used-value-equivalent to 0
Pass clamp(-1, 1 / sign(round(down, 0, infinity)), 1) should be used-value-equivalent to 1
Pass sign(round(down, 1, infinity)) should be used-value-equivalent to 0
Fail clamp(-1, 1 / sign(round(down, 1, infinity)), 1) should be used-value-equivalent to 1
Pass clamp(-1, 1 / sign(round(down, 1, infinity)), 1) should be used-value-equivalent to 1
Pass sign(mod(-1, -1)) should be used-value-equivalent to 0
Fail clamp(-1, 1 / sign(mod(-1, -1)), 1) should be used-value-equivalent to -1
Pass sign(mod(-1, 1)) should be used-value-equivalent to 0