eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Use a premade shape for NativeFunction with length and name

Browse Source 
~2% of the Speedometer 2.1 profile was just repeatedly performing the
shape transitions to add these two properties. We can avoid all that
work by caching a premade shape.
This commit is contained in:
Andreas Kling
2025-04-08 22:23:28 +02:00
committed by Andreas Kling
parent dbf6f7944e
commit 4e9bc0a437
Notes: github-actions[bot] 2025-04-09 05:23:00 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/4e9bc0a4377
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4289
Reviewed-by: https://github.com/Hendiadyoin1
5 changed files with 38 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibJS/Runtime/NativeFunction.cpp
View File

@@ -54,14 +54,16 @@ GC::Ref<NativeFunction> NativeFunction::create(Realm& allocating_realm, Function
// 9. Set func.[[InitialName]] to null.
auto function = allocating_realm.create<NativeFunction>(GC::create_function(vm.heap(), move(behaviour)), prototype, *realm.value());
function->unsafe_set_shape(realm.value()->intrinsics().native_function_shape());
// 10. Perform SetFunctionLength(func, length).
function->set_function_length(length);
function->put_direct(realm.value()->intrinsics().native_function_length_offset(), Value { length });
// 11. If prefix is not present, then
// a. Perform SetFunctionName(func, name).
// 12. Else,
// a. Perform SetFunctionName(func, name, prefix).
function->set_function_name(name, prefix);
function->put_direct(realm.value()->intrinsics().native_function_name_offset(), function->make_function_name(name, prefix));
// 13. Return func.
return function;