mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-28 02:27:19 +02:00
LibJS: Add shape caching for object literal instantiation
When a function creates object literals with simple property names, we now cache the resulting shape after the first instantiation. On subsequent calls, we create the object with the cached shape directly and write property values at their known offsets. This avoids repeated shape transitions and property offset lookups for a common JavaScript pattern. The optimization uses two new bytecode instructions: - CacheObjectShape: Captures the final shape after object construction - InitObjectLiteralProperty: Writes properties using cached offsets Only "simple" object literals are optimized (string literal keys with simple value expressions). Complex cases like computed properties, getters/setters, and spread elements use the existing slow path. 3.4x speedup on a microbenchmark that repeatedly instantiates an object literal with 26 properties. Small progressions on various benchmarks.
This commit is contained in:
committed by
Andreas Kling
parent
b37ee5d356
commit
505fe0a977
Notes:
github-actions[bot]
2026-01-09 23:57:41 +00:00
Author: https://github.com/awesomekling Commit: https://github.com/LadybirdBrowser/ladybird/commit/505fe0a9775 Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7406
@@ -76,6 +76,17 @@ struct TemplateObjectCache {
|
||||
GC::Ptr<Array> cached_template_object;
|
||||
};
|
||||
|
||||
// Cache for object literal shapes.
|
||||
// When an object literal like {a: 1, b: 2} is instantiated, we cache the final shape
|
||||
// so that subsequent instantiations can allocate the object with the correct shape directly,
|
||||
// avoiding repeated shape transitions.
|
||||
// We also cache the property offsets so that subsequent property writes can bypass
|
||||
// shape lookups and write directly to the correct storage slot.
|
||||
struct ObjectShapeCache {
|
||||
GC::Weak<Shape> shape;
|
||||
Vector<u32> property_offsets;
|
||||
};
|
||||
|
||||
struct SourceRecord {
|
||||
u32 source_start_offset {};
|
||||
u32 source_end_offset {};
|
||||
@@ -97,6 +108,7 @@ public:
|
||||
size_t number_of_property_lookup_caches,
|
||||
size_t number_of_global_variable_caches,
|
||||
size_t number_of_template_object_caches,
|
||||
size_t number_of_object_shape_caches,
|
||||
size_t number_of_registers,
|
||||
Strict);
|
||||
|
||||
@@ -107,6 +119,7 @@ public:
|
||||
Vector<PropertyLookupCache> property_lookup_caches;
|
||||
Vector<GlobalVariableCache> global_variable_caches;
|
||||
Vector<TemplateObjectCache> template_object_caches;
|
||||
Vector<ObjectShapeCache> object_shape_caches;
|
||||
NonnullOwnPtr<StringTable> string_table;
|
||||
NonnullOwnPtr<IdentifierTable> identifier_table;
|
||||
NonnullOwnPtr<PropertyKeyTable> property_key_table;
|
||||
|
||||
Reference in New Issue
Block a user