eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-02 20:42:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

HackStudio: Fix crash when clicking unstaged files

Browse Source 
In certain cases, an index might be invalid in the unstaged files view.
We must check if this index is valid before attempting to read the
index's data.
This commit is contained in:
Conor Byrne
2021-12-30 16:16:08 +00:00
committed by Andreas Kling
parent c0a3b1467c
commit 507ad1954f
Notes: sideshowbarker 2024-07-17 21:53:03 +09:00 
Author: https://github.com/caoimhebyrne
Commit: https://github.com/SerenityOS/serenity/commit/507ad1954f6
Pull-request: https://github.com/SerenityOS/serenity/pull/11509
Issue: https://github.com/SerenityOS/serenity/issues/8979
Reviewed-by: https://github.com/itamar8910 ✅
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/DevTools/HackStudio/Git/GitWidget.cpp
View File

@@ -45,6 +45,9 @@ GitWidget::GitWidget(const LexicalPath& repo_root)
Gfx::Bitmap::try_load_from_file("/res/icons/16x16/plus.png").release_value_but_fixme_should_propagate_errors());
m_unstaged_files->on_selection_change = [this] {
const auto& index = m_unstaged_files->selection().first();
if (!index.is_valid())
return;
const auto& selected = index.data().as_string();
show_diff(LexicalPath(selected));
};