eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Abort early processing frame/iframe attrs for null navigables

Browse Source 
We guarded one step against a null navigable, but the very next step
also needs to be protected. Let's just abort early instead. This was
caught by the following imported WPT test:

html/dom/elements/the-innertext-and-outertext-properties/innertext-setter.html

This test adds a <frame> element and immediately removes it, but the
task to process the src attribute is already queued. Note that <iframe>
would have the same issue, but this test does not include them.
This commit is contained in:
Timothy Flynn
2024-11-03 21:30:40 -05:00
committed by Tim Ledbetter
parent 16def85153
commit 50a31f9728
Notes: github-actions[bot] 2024-11-04 09:55:41 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/50a31f97284
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2152
Reviewed-by: https://github.com/tcl3 ✅
3 changed files with 30 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/HTMLFrameElement-add-remove.txt Normal file
View File

@@ -0,0 +1 @@
PASS! (Didn't crash)