eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Make RenderingThread own display list and backing stores

Browse Source 
This change prepares for a future where the rendering thread handles
input events directly, allowing it to trigger repainting without
waiting for the main thread. To support this, the compositor needs to
own the display list, scroll state, and backing stores rather than
receiving them per-frame from the main thread.
This commit is contained in:
Aliaksandr Kalenik
2026-01-26 12:59:43 +01:00
committed by Alexander Kalenik
parent 7bc7e80042
commit 516fb5f2fe
Notes: github-actions[bot] 2026-02-06 11:06:11 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/516fb5f2fe3
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7628
8 changed files with 251 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
Libraries/LibWeb/HTML/Navigable.cpp
View File

@@ -2767,41 +2767,16 @@ void Navigable::ready_to_paint()
VERIFY(m_number_of_queued_rasterization_tasks >= 0 && m_number_of_queued_rasterization_tasks < 2);
}
void Navigable::paint_next_frame()
{
if (!is_top_level_traversable())
return;
auto [backing_store_id, painting_surface] = m_backing_store_manager->acquire_store_for_next_frame();
if (!painting_surface)
return;
VERIFY(m_number_of_queued_rasterization_tasks <= 1);
m_number_of_queued_rasterization_tasks++;
auto viewport_rect = page().css_to_device_rect(this->viewport_rect()).to_type<int>();
PaintConfig paint_config { .paint_overlay = true, .should_show_line_box_borders = m_should_show_line_box_borders, .canvas_fill_rect = Gfx::IntRect { {}, viewport_rect.size() } };
auto page_client = &page().top_level_traversable()->page().client();
start_display_list_rendering(*painting_surface, paint_config, [page_client, viewport_rect, backing_store_id] {
if (!page_client)
return;
page_client->page_did_paint(viewport_rect, backing_store_id);
});
}
void Navigable::start_display_list_rendering(Gfx::PaintingSurface& painting_surface, PaintConfig paint_config, Function<void()>&& callback)
void Navigable::record_display_list_and_scroll_state(PaintConfig paint_config)
{
m_needs_repaint = false;
auto document = active_document();
if (!document) {
callback();
if (!document)
return;
}
auto display_list = document->record_display_list(paint_config);
if (!display_list) {
callback();
if (!display_list)
return;
}
auto& document_paintable = *document->paintable();
Painting::ScrollStateSnapshotByDisplayList scroll_state_snapshot_by_display_list;
@@ -2823,7 +2798,33 @@ void Navigable::start_display_list_rendering(Gfx::PaintingSurface& painting_surf
return TraversalDecision::Continue;
});
m_rendering_thread.enqueue_rendering_task(*display_list, move(scroll_state_snapshot_by_display_list), painting_surface, move(callback));
m_rendering_thread.update_display_list(*display_list, move(scroll_state_snapshot_by_display_list));
}
void Navigable::paint_next_frame()
{
if (!is_top_level_traversable())
return;
VERIFY(m_number_of_queued_rasterization_tasks <= 1);
m_number_of_queued_rasterization_tasks++;
auto viewport_rect = page().css_to_device_rect(this->viewport_rect()).to_type<int>();
PaintConfig paint_config { .paint_overlay = true, .should_show_line_box_borders = m_should_show_line_box_borders, .canvas_fill_rect = Gfx::IntRect { {}, viewport_rect.size() } };
record_display_list_and_scroll_state(paint_config);
auto page_client = &page().top_level_traversable()->page().client();
m_rendering_thread.present_frame([page_client, viewport_rect](i32 bitmap_id) {
if (page_client)
page_client->page_did_paint(viewport_rect, bitmap_id);
});
}
void Navigable::render_screenshot(Gfx::PaintingSurface& painting_surface, PaintConfig paint_config, Function<void()>&& callback)
{
record_display_list_and_scroll_state(paint_config);
m_rendering_thread.request_screenshot(painting_surface, move(callback));
}
RefPtr<Gfx::SkiaBackendContext> Navigable::skia_backend_context() const