eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't store root as JS::Handle in IntersectionObserver

Browse Source 
Instead, use a JS::GCPtr and visit it, to prevent GC reference cycles.
This commit is contained in:
Andreas Kling
2024-04-03 12:44:32 +02:00
parent 52fa415779
commit 518cedc8f3
Notes: sideshowbarker 2024-07-16 23:59:28 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/518cedc8f3
Pull-request: https://github.com/SerenityOS/serenity/pull/23815
Reviewed-by: https://github.com/ADKaster
2 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/IntersectionObserver/IntersectionObserver.h
View File

@@ -73,7 +73,7 @@ private:
JS::GCPtr<WebIDL::CallbackType> m_callback;
// https://www.w3.org/TR/intersection-observer/#dom-intersectionobserver-root
Optional<Variant<JS::Handle<DOM::Element>, JS::Handle<DOM::Document>>> m_root;
JS::GCPtr<DOM::Node> m_root;
// https://www.w3.org/TR/intersection-observer/#dom-intersectionobserver-thresholds
Vector<double> m_thresholds;