eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/IDB: Implement IDBTransaction attributes

Browse Source 
This also uncovered a bug, where the transactions type was never set :^)
This commit is contained in:
stelar7
2025-04-01 19:51:22 +02:00
committed by Andrew Kaster
parent 718c805e95
commit 5298ecfc94
Notes: github-actions[bot] 2025-04-09 17:50:19 +00:00 
Author: https://github.com/stelar7
Commit: https://github.com/LadybirdBrowser/ladybird/commit/5298ecfc942
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4178
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/AtkinsSJ
7 changed files with 63 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2024, stelar7 <dudedbz@gmail.com>
* Copyright (c) 2024-2025, stelar7 <dudedbz@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@@ -312,9 +312,8 @@ GC::Ref<IDBTransaction> upgrade_a_database(JS::Realm& realm, GC::Ref<IDBDatabase
auto db = connection->associated_database();
// 2. Let transaction be a new upgrade transaction with connection used as connection.
auto transaction = IDBTransaction::create(realm, connection);
// FIXME: 3. Set transaction’s scope to connection’s object store set.
// 3. Set transaction’s scope to connection’s object store set.
auto transaction = IDBTransaction::create(realm, connection, Bindings::IDBTransactionMode::Versionchange, Bindings::IDBTransactionDurability::Default, Vector<GC::Ref<ObjectStore>> { connection->object_store_set() });
// 4. Set db’s upgrade transaction to transaction.
db->set_upgrade_transaction(transaction);