eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/Bindings: Factor generate_promise_to_cpp into function

Browse Source
This commit is contained in:
Shannon Booth
2026-04-13 22:10:30 +02:00
committed by Sam Atkins
parent 69fb476e76
commit 536052c3c8
Notes: github-actions[bot] 2026-04-17 14:52:33 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/536052c3c8b
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8962
Reviewed-by: https://github.com/AtkinsSJ ✅
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View File

@@ -758,6 +758,19 @@ static void generate_dictionary_to_cpp(SourceGenerator& generator, IDL::Interfac
}
}
static void generate_promise_to_cpp(SourceGenerator& scoped_generator)
{
// https://webidl.spec.whatwg.org/#js-promise
scoped_generator.append(R"~~~(
// 1. Let promiseCapability be ? NewPromiseCapability(%Promise%).
auto promise_capability = TRY(JS::new_promise_capability(vm, realm.intrinsics().promise_constructor()));
// 2. Perform ? Call(promiseCapability.[[Resolve]], undefined, « V »).
TRY(JS::call(vm, *promise_capability->resolve(), JS::js_undefined(), @js_name@@js_suffix@));
// 3. Return promiseCapability.
auto @cpp_name@ = GC::make_root(promise_capability);
)~~~");
}
static void generate_object_to_cpp(SourceGenerator& scoped_generator, IDL::Type const& type, bool optional)
{
// https://webidl.spec.whatwg.org/#js-object
@@ -926,15 +939,7 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter
}
}
} else if (parameter.type->name() == "Promise") {
// https://webidl.spec.whatwg.org/#js-promise
scoped_generator.append(R"~~~(
// 1. Let promiseCapability be ? NewPromiseCapability(%Promise%).
auto promise_capability = TRY(JS::new_promise_capability(vm, realm.intrinsics().promise_constructor()));
// 2. Perform ? Call(promiseCapability.[[Resolve]], undefined, « V »).
TRY(JS::call(vm, *promise_capability->resolve(), JS::js_undefined(), @js_name@@js_suffix@));
// 3. Return promiseCapability.
auto @cpp_name@ = GC::make_root(promise_capability);
)~~~");
generate_promise_to_cpp(scoped_generator);
} else if (parameter.type->name() == "object") {
generate_object_to_cpp(scoped_generator, *parameter.type, optional);
} else if (is_javascript_builtin(parameter.type) || parameter.type->name() == "BufferSource"sv) {