eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Replace PropertyKey(char[]) with PropertyKey(FlyString)

Browse Source 
...and deal with the fallout.
This commit is contained in:
Andreas Kling
2025-03-16 21:25:29 -05:00
committed by Andreas Kling
parent d7908dbff5
commit 53da8893ac
Notes: github-actions[bot] 2025-03-24 22:28:43 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/53da8893acb
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4067
Reviewed-by: https://github.com/trflynn89
55 changed files with 254 additions and 251 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibTest/JavaScriptTestRunner.h
View File

@@ -185,7 +185,7 @@ inline void TestRunnerGlobalObject::initialize(JS::Realm& realm)
{
Base::initialize(realm);
define_direct_property("global", this, JS::Attribute::Enumerable);
define_direct_property("global"_fly_string, this, JS::Attribute::Enumerable);
for (auto& entry : s_exposed_global_functions) {
define_native_function(
realm,
@@ -242,7 +242,7 @@ inline AK::Result<GC::Ref<JS::SourceTextModule>, ParserError> parse_module(Strin
inline ErrorOr<JsonValue> get_test_results(JS::Realm& realm)
{
auto results = MUST(realm.global_object().get("__TestResults__"));
auto results = MUST(realm.global_object().get("__TestResults__"_fly_string));
auto maybe_json_string = MUST(JS::JSONObject::stringify_impl(*g_vm, results, JS::js_undefined(), JS::js_undefined()));
if (maybe_json_string.has_value())
return JsonValue::from_string(*maybe_json_string);
@@ -362,7 +362,7 @@ inline JSFileResult TestRunner::run_file_test(ByteString const& test_path)
JSFileResult file_result { test_path.substring(m_test_root.length() + 1, test_path.length() - m_test_root.length() - 1) };
// Collect logged messages
auto user_output = MUST(realm->global_object().get("__UserOutput__"));
auto user_output = MUST(realm->global_object().get("__UserOutput__"_fly_string));
auto& arr = user_output.as_array();
for (auto& entry : arr.indexed_properties()) {