eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 13:02:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Implement 'less than' for a String over code units

Browse Source 
...Instead of code points.
This commit is contained in:
Shannon Booth
2025-05-15 17:58:28 +12:00
committed by Tim Flynn
parent d1a40b7951
commit 5495531118
Notes: github-actions[bot] 2025-05-17 12:01:57 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/5495531118a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4740
Reviewed-by: https://github.com/stelar7
Reviewed-by: https://github.com/trflynn89
2 changed files with 22 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Libraries/LibJS/Tests/builtins/String/String.js
View File

@@ -40,3 +40,18 @@ test("properties", () => {
expect(Object.getOwnPropertyNames("abc")).toEqual(["0", "1", "2", "length"]);
expect(Object.getOwnPropertyNames("😀")).toEqual(["0", "1", "length"]);
});
test("less than", () => {
expect("a" < "").toBe(false);
expect("a" < "b").toBe(true);
expect("a" < "aa").toBe(true);
expect("aa" < "a").toBe(false);
expect("abc" < "abd").toBe(true);
expect("abc" < "abcd").toBe(true);
expect("😀" < "😁").toBe(true);
expect("" < "😁").toBe(true);
expect("😁" < "").toBe(false);
expect("a" < "A").toBe(false);
expect("a" < "a").toBe(false);
expect("～" < "😀").toBe(false);
});