eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Consolidate transition computation

Browse Source 
Previously the logic to compute transitions was split across
`ComputedProperties`, `StyleComputer`, and `Animatable` - this commit
consolidates it all in `ComputedProperties`
This commit is contained in:
Callum Law
2025-12-28 12:07:09 +13:00
committed by Sam Atkins
parent 3353ec9663
commit 558f034007
Notes: github-actions[bot] 2026-01-05 11:36:59 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/558f0340075
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7255
Reviewed-by: https://github.com/AtkinsSJ ✅
6 changed files with 80 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
Libraries/LibWeb/CSS/ComputedProperties.cpp
View File

@@ -2443,6 +2443,68 @@ Vector<ComputedProperties::AnimationProperties> ComputedProperties::animations()
return animations;
}
Vector<TransitionProperties> ComputedProperties::transitions() const
{
auto const& coordinated_properties = assemble_coordinated_value_list(
PropertyID::TransitionProperty,
{ PropertyID::TransitionProperty, PropertyID::TransitionDuration, PropertyID::TransitionTimingFunction, PropertyID::TransitionDelay, PropertyID::TransitionBehavior });
auto const& property_values = coordinated_properties.get(PropertyID::TransitionProperty).value();
auto const& duration_values = coordinated_properties.get(PropertyID::TransitionDuration).value();
auto const& timing_function_values = coordinated_properties.get(PropertyID::TransitionTimingFunction).value();
auto const& delay_values = coordinated_properties.get(PropertyID::TransitionDelay).value();
auto const& behavior_values = coordinated_properties.get(PropertyID::TransitionBehavior).value();
Vector<TransitionProperties> transitions;
transitions.ensure_capacity(property_values.size());
for (size_t i = 0; i < property_values.size(); i++) {
auto properties = [&]() -> Vector<PropertyID> {
auto const& property_value = property_values[i];
if (property_value->is_keyword() && property_value->to_keyword() == Keyword::None)
return {};
auto maybe_property = property_id_from_string(property_value->as_custom_ident().custom_ident());
if (!maybe_property.has_value())
return {};
Vector<PropertyID> properties;
auto const append_property_mapping_logical_aliases = [&](PropertyID property_id) {
if (property_is_logical_alias(property_id))
properties.append(map_logical_alias_to_physical_property(property_id, LogicalAliasMappingContext { writing_mode(), direction() }));
else if (property_id != PropertyID::Custom)
properties.append(property_id);
};
auto transition_property = maybe_property.release_value();
if (property_is_shorthand(transition_property)) {
auto expanded_longhands = expanded_longhands_for_shorthand(transition_property);
properties.ensure_capacity(expanded_longhands.size());
for (auto const& prop : expanded_longhands_for_shorthand(transition_property))
append_property_mapping_logical_aliases(prop);
} else {
append_property_mapping_logical_aliases(transition_property);
}
return properties;
}();
transitions.append(TransitionProperties {
.properties = properties,
.duration = Time::from_style_value(duration_values[i], {}).to_milliseconds(),
.timing_function = EasingFunction::from_style_value(timing_function_values[i]),
.delay = Time::from_style_value(delay_values[i], {}).to_milliseconds(),
.transition_behavior = keyword_to_transition_behavior(behavior_values[i]->to_keyword()).value(),
});
}
return transitions;
}
MaskType ComputedProperties::mask_type() const
{
auto const& value = property(PropertyID::MaskType);