eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 04:52:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use correct factory function when cloning a Document node

Browse Source 
Cloning an XMLDocument should produce a new XMLDocument. Same for
HTMLDocument.

This fixes at least one WPT test, which we're also importing. :^)
This commit is contained in:
Andreas Kling
2024-11-19 15:16:14 +01:00
committed by Tim Ledbetter
parent 24a6fd3d76
commit 564dc0a434
Notes: github-actions[bot] 2024-11-19 19:25:40 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/564dc0a434b
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2441
Reviewed-by: https://github.com/tcl3 ✅
3 changed files with 51 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
Tests/LibWeb/Text/input/wpt-import/dom/nodes/Node-cloneNode-XMLDocument.html Normal file
View File

@@ -0,0 +1,28 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Cloning of an XMLDocument</title>
<link rel="help" href="https://dom.spec.whatwg.org/#dom-node-clonenode">
<link rel="help" href="https://dom.spec.whatwg.org/#concept-node-clone">
<!-- This is testing in particular "that implements the same interfaces as node" -->
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script>
"use strict";
test(() => {
const doc = document.implementation.createDocument("namespace", "");
assert_equals(
doc.constructor, XMLDocument,
"Precondition check: document.implementation.createDocument() creates an XMLDocument"
);
const clone = doc.cloneNode(true);
assert_equals(clone.constructor, XMLDocument);
}, "Created with createDocument");
</script>