eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 13:02:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/IDB: Fix a bug where the KeyGenerator was not incremented

Browse Source
This commit is contained in:
stelar7
2025-04-25 18:12:28 +02:00
committed by Jelle Raaijmakers
parent facfcd87c2
commit 577f799240
Notes: github-actions[bot] 2025-04-28 09:32:51 +00:00 
Author: https://github.com/stelar7
Commit: https://github.com/LadybirdBrowser/ladybird/commit/577f7992407
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4476
Reviewed-by: https://github.com/gmta ✅
4 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp
View File

@@ -1220,7 +1220,7 @@ GC::Ref<IDBRequest> asynchronously_execute_a_request(JS::Realm& realm, IDBReques
ErrorOr<u64> generate_a_key(GC::Ref<ObjectStore> store)
{
// 1. Let generator be store’s key generator.
auto generator = store->key_generator().value();
auto& generator = store->key_generator();
// 2. Let key be generator’s current number.
auto key = generator.current_number();
@@ -1253,7 +1253,7 @@ void possibly_update_the_key_generator(GC::Ref<ObjectStore> store, GC::Ref<Key>
u64 value = floor(temp_value);
// 5. Let generator be store’s key generator.
auto generator = store->key_generator().value();
auto& generator = store->key_generator();
// 6. If value is greater than or equal to generator’s current number, then set generator’s current number to value + 1.
if (value >= generator.current_number())
@@ -1324,7 +1324,7 @@ void delete_records_from_an_object_store(GC::Ref<ObjectStore> store, GC::Ref<IDB
WebIDL::ExceptionOr<GC::Ptr<Key>> store_a_record_into_an_object_store(JS::Realm& realm, GC::Ref<ObjectStore> store, JS::Value value, GC::Ptr<Key> key, bool no_overwrite)
{
// 1. If store uses a key generator, then:
if (store->key_generator().has_value()) {
if (store->uses_a_key_generator()) {
// 1. If key is undefined, then:
if (key == nullptr) {
// 1. Let key be the result of generating a key for store.