eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Fix OBOE in bounds check of ResolvedCSSStyleDeclaration#item

Browse Source 
Without this, it would return "(invalid CSS::PropertyID)" when
requesting item(decl.length).
This commit is contained in:
Luke Wilde
2024-11-14 15:37:48 +00:00
committed by Andreas Kling
parent 1a1fb14e26
commit 5aacb053a3
Notes: github-actions[bot] 2024-11-14 18:51:40 +00:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/5aacb053a3f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2346
3 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/CSS/ResolvedCSSStyleDeclaration.cpp
View File

@@ -76,7 +76,7 @@ String ResolvedCSSStyleDeclaration::item(size_t index) const
{
// The item(index) method must return the property name of the CSS declaration at position index.
// FIXME: Return custom properties if index > last_longhand_property_id.
if (index > length())
if (index >= length())
return {};
auto property_id = static_cast<PropertyID>(index + to_underlying(first_longhand_property_id));
return string_from_property_id(property_id).to_string();