eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-12 18:08:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/Bindings: Generate struct definitions from IDL dictionaries

Browse Source 
Previously we were inconsistent by generating code for enum definitions
but not generating code for dictionaries. With future changes to the
IDL generator to expose helpers to convert to and from IDL values
this produced circular depdendencies. To solve this problem, also
generate the dictionary definitions in bindings headers.
This commit is contained in:
Shannon Booth
2026-05-01 19:01:23 +02:00
committed by Andreas Kling
parent 7ad946c669
commit 5adfd1c43a
Notes: github-actions[bot] 2026-05-09 08:51:32 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/5adfd1c43a8
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9094
Reviewed-by: https://github.com/AtkinsSJ
406 changed files with 1963 additions and 2837 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -19,6 +19,7 @@
#include <LibJS/Runtime/RegExpObject.h>
#include <LibURL/Parser.h>
#include <LibWeb/Bindings/HTMLInputElement.h>
#include <LibWeb/Bindings/InputEvent.h>
#include <LibWeb/Bindings/PrincipalHostDefined.h>
#include <LibWeb/CSS/CSSStyleProperties.h>
#include <LibWeb/CSS/ComputedProperties.h>
@@ -638,7 +639,7 @@ void HTMLInputElement::did_select_files(Span<SelectedFile> selected_files, Multi
auto file_name = MUST(String::from_byte_string(selected_file.name()));
// FIXME: Fill in other fields (e.g. last_modified).
FileAPI::FilePropertyBag options {};
Bindings::FilePropertyBag options {};
options.type = mime_type.essence();
auto file = MUST(FileAPI::File::create(realm(), { GC::make_root(blob) }, file_name, move(options)));
@@ -1199,7 +1200,7 @@ void HTMLInputElement::create_text_input_shadow_tree()
},
0, Utf16FlyString {}, &realm());
auto mouseup_callback = realm().heap().allocate<WebIDL::CallbackType>(*mouseup_callback_function, realm());
DOM::AddEventListenerOptions mouseup_listener_options;
Bindings::AddEventListenerOptions mouseup_listener_options;
mouseup_listener_options.once = true;
auto up_callback_function = JS::NativeFunction::create(
@@ -1445,7 +1446,7 @@ void HTMLInputElement::create_range_input_shadow_tree()
},
0, Utf16FlyString {}, &realm());
auto mouseup_callback = realm().heap().allocate<WebIDL::CallbackType>(*mouseup_callback_function, realm());
DOM::AddEventListenerOptions mouseup_listener_options;
Bindings::AddEventListenerOptions mouseup_listener_options;
mouseup_listener_options.once = true;
window.add_event_listener(UIEvents::EventNames::mouseup, DOM::IDLEventListener::create(realm(), mouseup_callback), mouseup_listener_options);
@@ -1465,10 +1466,10 @@ void HTMLInputElement::user_interaction_did_change_input_value(FlyString const&
// given the input element to fire an event named input at the input element, with the bubbles and composed attributes initialized to true
queue_an_element_task(HTML::Task::Source::UserInteraction, [this, input_type, data] {
// https://w3c.github.io/uievents/#event-type-input
UIEvents::InputEventInit input_event_init;
Bindings::InputEventInit input_event_init;
input_event_init.bubbles = true;
input_event_init.composed = true;
input_event_init.input_type = input_type;
input_event_init.input_type = input_type.to_string();
input_event_init.data = data;
auto input_event = UIEvents::InputEvent::create_from_platform_event(realm(), HTML::EventNames::input, input_event_init);
dispatch_event(*input_event);