eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Implement report_validity

Browse Source 
This implements the previously stubbed out `report_validity` method.

The specification is not very clear on how to exactly report the
validity. For now, we bring the first visible invalid control into
view and focus it. In the future, however, it would make sense to
support more complex scenarios and be more aligned with the other
implementations.
This commit is contained in:
Glenn Skrzypczak
2025-05-03 19:52:01 +02:00
committed by Shannon Booth
parent 296d9d74d8
commit 5c578b6057
Notes: github-actions[bot] 2025-05-13 21:40:10 +00:00 
Author: https://github.com/skyz1
Commit: https://github.com/LadybirdBrowser/ladybird/commit/5c578b60571
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4578
Reviewed-by: https://github.com/Psychpsyo
Reviewed-by: https://github.com/shannonbooth ✅
11 changed files with 363 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
Libraries/LibWeb/HTML/HTMLFormElement.cpp
View File

@@ -17,6 +17,7 @@
#include <LibWeb/DOMURL/DOMURL.h>
#include <LibWeb/HTML/BrowsingContext.h>
#include <LibWeb/HTML/EventNames.h>
#include <LibWeb/HTML/Focus.h>
#include <LibWeb/HTML/FormControlInfrastructure.h>
#include <LibWeb/HTML/HTMLButtonElement.h>
#include <LibWeb/HTML/HTMLDialogElement.h>
@@ -599,6 +600,41 @@ HTMLFormElement::StaticValidationResult HTMLFormElement::statically_validate_con
return { false, unhandled_invalid_controls };
}
// https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#interactively-validate-the-constraints
bool HTMLFormElement::interactively_validate_constraints()
{
// 1. Statically validate the constraints of form, and let unhandled invalid controls be the list of elements returned if the result was negative.
// 2. If the result was positive, then return that result.
auto static_validation_result = statically_validate_constraints();
if (static_validation_result.result)
return true;
auto unhandled_invalid_controls = static_validation_result.unhandled_invalid_controls;
// 3. Report the problems with the constraints of at least one of the elements given in unhandled invalid controls to the user.
// - User agents may focus one of those elements in the process, by running the focusing steps for that element, and may change the
// scrolling position of the document, or perform some other action that brings the element to the user's attention.
// For elements that are form-associated custom elements, user agents should use their validation anchor instead, for the purposes of these actions.
// - User agents may report more than one constraint violation.
// - User agents may coalesce related constraint violation reports if appropriate (e.g. if multiple radio buttons in a group are marked as required, only one error need be reported).
// - If one of the controls is not being rendered (e.g. it has the hidden attribute set) then user agents may report a script error.
// FIXME: Does this align with other browsers?
auto first_invalid_control = unhandled_invalid_controls.first_matching([](auto control) {
return control->check_visibility({});
});
if (first_invalid_control.has_value()) {
auto control = first_invalid_control.release_value();
run_focusing_steps(control);
DOM::ScrollIntoViewOptions scroll_options;
scroll_options.block = Bindings::ScrollLogicalPosition::Nearest;
scroll_options.inline_ = Bindings::ScrollLogicalPosition::Nearest;
scroll_options.behavior = Bindings::ScrollBehavior::Instant;
(void)control->scroll_into_view(scroll_options);
}
// 4. Return a negative result.
return false;
}
// https://html.spec.whatwg.org/multipage/forms.html#dom-form-checkvalidity
WebIDL::ExceptionOr<bool> HTMLFormElement::check_validity()
{
@@ -608,8 +644,7 @@ WebIDL::ExceptionOr<bool> HTMLFormElement::check_validity()
// https://html.spec.whatwg.org/multipage/forms.html#dom-form-reportvalidity
WebIDL::ExceptionOr<bool> HTMLFormElement::report_validity()
{
dbgln("(STUBBED) HTMLFormElement::report_validity(). Called on: {}", debug_description());
return true;
return interactively_validate_constraints();
}
// https://html.spec.whatwg.org/multipage/forms.html#category-submit