eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 10:07:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Don't set a prototype property on async functions

Browse Source 
This is now as defined in the spec. However since we execute async
functions in bytecode by transforming it to a generator function it must
have a prototype for the GeneratorObject. We check whether it is an
async function and in that case use the hardcoded generator object
prototype. This also ensures that user code cannot override this
property thus preventing exposing internal implementation details.
This commit is contained in:
davidot
2021-11-15 01:48:55 +01:00
committed by Linus Groh
parent de46a2cff1
commit 5d0f666f22
Notes: sideshowbarker 2024-07-18 00:53:21 +09:00 
Author: https://github.com/davidot
Commit: https://github.com/SerenityOS/serenity/commit/5d0f666f22d
Pull-request: https://github.com/SerenityOS/serenity/pull/10926
Reviewed-by: https://github.com/linusg ✅
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
View File

@@ -101,10 +101,11 @@ void ECMAScriptFunctionObject::initialize(GlobalObject& global_object)
MUST(prototype->define_property_or_throw(vm.names.constructor, { .value = this, .writable = true, .enumerable = false, .configurable = true }));
break;
case FunctionKind::Generator:
case FunctionKind::Async:
// prototype is "g1.prototype" in figure-2 (https://tc39.es/ecma262/img/figure-2.png)
prototype = global_object.generator_object_prototype();
break;
case FunctionKind::Async:
break;
}
define_direct_property(vm.names.prototype, prototype, Attribute::Writable);
}