eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 13:02:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Prevent failing IDB requests from clobbering previous ones

Browse Source 
If one request on a transaction succeeds, then the next one fails, that
would cause the abort algorithm to run before the success for the first
request due to the task queue ordering. Instead, queue the processing
for the next request after the completion of the current request.
This commit is contained in:
Zaggy1024
2026-03-05 23:04:32 -06:00
committed by Gregory Bertilson
parent 2c48aa0b67
commit 5ff1ae1876
Notes: github-actions[bot] 2026-03-21 05:00:36 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/5ff1ae1876c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8295
4 changed files with 63 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Tests/LibWeb/Text/expected/wpt-import/IndexedDB/idb-explicit-commit.any.txt
View File

@@ -2,8 +2,7 @@ Harness status: OK
Found 12 tests
11 Pass
1 Fail
12 Pass
Pass Explicitly committed data can be read back out.
Pass commit() on a version change transaction does not cause errors.
Pass A committed transaction becomes inactive immediately.
@@ -14,5 +13,5 @@ Pass Calling commit on a committed transaction throws.
Pass Calling abort on a committed transaction throws and does not prevent persisting the data.
Pass Calling txn.commit() when txn is inactive should throw.
Pass Transactions with same scope should stay in program order, even if one calls commit.
Fail Transactions that explicitly commit and have errors should abort.
Pass Transactions that explicitly commit and have errors should abort.
Pass Transactions that handle all errors properly should behave as expected when an explicit commit is called in an onerror handler.