LibWeb: Prevent failing IDB requests from clobbering previous ones

If one request on a transaction succeeds, then the next one fails, that would cause the abort algorithm to run before the success for the first request due to the task queue ordering. Instead, queue the processing for the next request after the completion of the current request.
Author: https://github.com/Zaggy1024 Commit: https://github.com/LadybirdBrowser/ladybird/commit/5ff1ae1876c Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8295
2026-05-03 04:52:06 +02:00 · 2026-03-05 23:04:32 -06:00 · 2026-03-21 05:00:36 +00:00
parent 2c48aa0b67
commit 5ff1ae1876
4 changed files with 63 additions and 6 deletions
--- a/Tests/LibWeb/Text/input/indexeddb-commit-error-event-order.html
+++ b/Tests/LibWeb/Text/input/indexeddb-commit-error-event-order.html
@@ -0,0 +1,52 @@
+<!DOCTYPE html>
+<script src="include.js"></script>
+<script>
+asyncTest(done => {
+    setTimeout(() => {
+        spoofCurrentURL("https://example.com/");
+
+        const openReq = indexedDB.open("commit-error-event-order", 1);
+        openReq.onupgradeneeded = (e) => {
+            const db = e.target.result;
+            db.createObjectStore("store", { keyPath: "key" });
+        };
+        openReq.onsuccess = (e) => {
+            const db = e.target.result;
+
+            // First transaction: insert key "one"
+            const txn1 = db.transaction("store", "readwrite");
+            txn1.objectStore("store").add({ key: "one", value: "first" });
+            txn1.oncomplete = () => {
+                // Second transaction: put + add(duplicate) + commit
+                const txn2 = db.transaction("store", "readwrite");
+                const store2 = txn2.objectStore("store");
+
+                const putReq = store2.put({ key: "two", value: "second" });
+                putReq.onsuccess = () => println("put:success");
+                putReq.onerror = () => println("put:error");
+
+                const addReq = store2.add({ key: "one", value: "duplicate" });
+                addReq.onsuccess = () => println("add:success");
+                addReq.onerror = (ev) => {
+                    println("add:error");
+                    ev.preventDefault();
+                };
+
+                txn2.addEventListener("error", () => println("tx:error"));
+                txn2.addEventListener("abort", () => {
+                    println("tx:abort");
+                    db.close();
+                    done();
+                });
+                txn2.addEventListener("complete", () => {
+                    println("tx:complete");
+                    db.close();
+                    done();
+                });
+
+                txn2.commit();
+            };
+        };
+    }, 0);
+});
+</script>