eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Define constructor slots for describing how to read options

Browse Source 
This is an editorial change in the ECMA-402 spec. See:
https://github.com/tc39/ecma402/commit/a2beb66

We implement this change by introducing a virtual interface that all
Intl "service" objects must implement. A future patch will make use of
the virtualized RelevantExtensionKeys and ResolutionOptionDescriptors
accessors, and we will need to be able to use those slots from a generic
instance type.
This commit is contained in:
Timothy Flynn
2025-04-07 15:56:31 -04:00
committed by Tim Flynn
parent 19ce186f97
commit 62793b1bd8
Notes: github-actions[bot] 2025-04-08 10:53:24 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/62793b1bd88
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4275
29 changed files with 284 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Libraries/LibJS/Runtime/Intl/DateTimeFormat.h
View File

@@ -13,28 +13,24 @@
#include <AK/Vector.h>
#include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/Intl/DateTimeFormatConstructor.h>
#include <LibJS/Runtime/Object.h>
#include <LibJS/Runtime/Intl/IntlObject.h>
#include <LibJS/Runtime/VM.h>
#include <LibUnicode/DateTimeFormat.h>
namespace JS::Intl {
class DateTimeFormat final : public Object {
JS_OBJECT(DateTimeFormat, Object);
class DateTimeFormat final : public IntlObject {
JS_OBJECT(DateTimeFormat, IntlObject);
GC_DECLARE_ALLOCATOR(DateTimeFormat);
using Patterns = Unicode::CalendarPattern;
public:
static constexpr auto relevant_extension_keys()
{
// 11.2.3 Internal slots, https://tc39.es/ecma402/#sec-intl.datetimeformat-internal-slots
// The value of the [[RelevantExtensionKeys]] internal slot is « "ca", "hc", "nu" ».
return AK::Array { "ca"sv, "hc"sv, "nu"sv };
}
virtual ~DateTimeFormat() override = default;
virtual ReadonlySpan<StringView> relevant_extension_keys() const override;
virtual ReadonlySpan<ResolutionOptionDescriptor> resolution_option_descriptors(VM&) const override;
String const& locale() const { return m_locale; }
void set_locale(String locale) { m_locale = move(locale); }
@@ -90,7 +86,7 @@ public:
void set_temporal_time_zone(String temporal_time_zone) { m_temporal_time_zone = move(temporal_time_zone); }
private:
DateTimeFormat(Object& prototype);
explicit DateTimeFormat(Object& prototype);
virtual void visit_edges(Visitor&) override;